emuikernel / wittytwitter

Automatically exported from code.google.com/p/wittytwitter
1 stars 0 forks source link

TinyUrl Helper Does Not Consider http://www.foo.com/x a Url #82

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Tweet something with a Url like
http://code.google.com/p/wittytwitter/issues/entry
2. Observe that the url does not get tinyurl'd.

Disclaimer: I am a regex hater and just grabbed the first regex I found
that passed my handful of tests. If you have more regex skills than my
google search, don't be shy. This is the regex I started with and just
added the https protocol part: http://turl.ca/pawsm

I added binaries for the testing framework I used, hence the zip. Unzip
into where you checked out trunk.

Original issue reported on code.google.com by cbil...@gmail.com on 18 Feb 2008 at 6:19

Attachments:

GoogleCodeExporter commented 8 years ago
Here's an even better IsUrl, which doesn't even use regex. This supplants my 
previous
patch (but not the binaries zip.) 

Original comment by cbil...@gmail.com on 18 Feb 2008 at 6:33

Attachments:

GoogleCodeExporter commented 8 years ago
thanks cbilson. I'll check it out.

Original comment by alan...@gmail.com on 19 Feb 2008 at 5:03

GoogleCodeExporter commented 8 years ago
wow, you have a non-regex IsUrl. neat stuff.

Original comment by alan...@gmail.com on 25 Mar 2008 at 5:37

GoogleCodeExporter commented 8 years ago
I totally refactored url related code base on your patch.

Original comment by alan...@gmail.com on 25 Mar 2008 at 7:01