emukidid / cleanrip

Disc Backup Tool for GC/Wii Discs
GNU General Public License v2.0
301 stars 37 forks source link

"Remember these settings?" incorrectly saves settings for both disc types #67

Closed Kazuto88 closed 4 years ago

Kazuto88 commented 4 years ago

This was discovered on the current version, 2.1.1. I started by ripping my GCN games. I chose "No" for using a Datel disc, then "Yes" to remember these settings. After finishing with GCN, I switched to a Wii disc, a dual-layer disc no less, and was never prompted to pick Wii-specific settings, such as dual-layer, chunk size, or new device per-chunk.

Presumably, the rip proceeded with default settings, as I wound up with 5 chunks, and it kept prompting me to connect the next device.

EDIT: After posting, I realized the dual-layer option is really something that shouldn't be persistent for the session. Why? Because when you lock-in a setting for that, it forces you to close out in order to rip a disc of the other type, rather than being able to use the same device settings and just pick, per-game, whether it's a dual-layer disc. I know the number of dual-layer game discs is slim, but still.