search

emukidid / cleanrip

Disc Backup Tool for GC/Wii Discs
GNU General Public License v2.0
301 stars 37 forks source link

create new folder per dump #75

Open schicho opened 4 years ago

schicho commented 4 years ago

Reduces the clutter in the root directory and also makes it easier to find the corresponding files.

schicho commented 4 years ago

If there are better naming suggestions - I bet there are, please let me know!

My idea behind adding timestamps was so that when you aborted a dump and started it again the folder creation would fail. You technically could check that and just use the old folder, but other possibly corrupted files would still be in there. So I went with completely new folder per dump.

emukidid commented 4 years ago

I like this but can we make it an option "Create directory per dump [Yes/No]"? I'm happy for it to always come under cleanrip-dumps or whatever though, dumping to the root was never a good idea 😂

schicho commented 4 years ago

If I implement an option for it, it would require a lot of checks in the several dumping/writing functions (dump_bca, dump_game, dump_info) to control wether to write to /cleanrip-dumps/ or /cleanrip-dumps/gamename/ .

That will result in a lot of duplication and probably does not make the code very readable.

You decide. I can implement it, but I don't think it's great that way.

As the middle way, I can also just change it to use /cleanrip-dumps/ , which is still an improvment over dumping straight into the root directory.

MasterLuma commented 2 years ago

Can this still be implemented??