search

emukidid / pcsxgc

A port of the PS1 emulator, PCSX, to the Nintendo GC/Wii
117 stars 7 forks source link

dfsound: Fix reverb #16

Closed pcercuei closed 1 year ago

pcercuei commented 1 year ago

Fix the reverb code to work on big-endian systems.

Upstream PR: https://github.com/notaz/pcsx_rearmed/pull/292

saulfabregwiivc commented 1 year ago

I could try to compile your fixes you submitted at PCSXGC and test it on Wii with Vib-Ribbon. It's on of my favorite PS1 games xD

saulfabregwiivc commented 1 year ago

@pcercuei

I have tested the compiled build, but the BIOS sound is still without the "echo" (reverb) effect and Vib-Ribbon still has no music. Seeing your changes, you forgot to change a setting here, so i opened a PR for complement your fixes: https://github.com/emukidid/pcsxgc/pull/18/files

EDIT: Compiled your reverb branch of PCSXGC, with my change on enabling the Reverb setting on PCSXGC, and the BIOS echo and the music on Vib-Ribbon now actually works fine, and the music audio in Vib-Ribbon is so clear. You just forgot to enable reverb on PCSXGC's internal settings, lol

pcercuei commented 1 year ago

I didn't forget. We decided it was better to have a menu option.