emukidid / pcsxgc

A port of the PS1 emulator, PCSX, to the Nintendo GC/Wii
117 stars 7 forks source link

WiiSX doesn't save control configs from USB after reset #43

Open TheArcadeStriker opened 11 months ago

TheArcadeStriker commented 11 months ago

First of all, I have just tested the latest version with the commit that closed the issue I posted last time...and the issue was indeed fixed; settings are finally saving, and memcard save/load works properly!!

That was a huge relief to finally see fixed, but unfortunately one thing I still noticed is that saving control profiles to USB doesn't seem to be fixed. Specifically, I think the save/load control slot options work on a single session, but when I changed the D-Pad to be used with the Analog Stick (setting them to A-Up/Down/Left/Right for games that only use the D-Pad), saved to Slot 1, pressed "Save Control Settings to USB", and then closed and reopened WiiSX, the Load Slot 1 option didn't find the profile I thought that got saved. Once again I don't know if this only happens with USB drives, but this might be the only oversight of that kind left, as every other setting actually now saved and loaded fine between resets since that commit (like the load saves and BIOS, the frameskip settings, aspect ratio, etc).

emukidid commented 11 months ago

It looks like Slot saving on the Configure Button Mappings screen was never actually implemented back in the day. This will need to be done.