emukidid / swiss-gc

Swiss - The swiss army knife of GameCube homebrew
GNU General Public License v2.0
1.28k stars 93 forks source link

[Issue]: Nintendo Puzzle Collection (GPZJ01), Reset Quirk and 1:1 Horizontal Scale doesn't seem to apply to N64 ports #759

Open Rulumi opened 1 year ago

Rulumi commented 1 year ago

Describe the bug

On Nintendo Puzzle Collection forcing a 1:1 horizontal scale doesn't seem to apply to the games ported from the N64 (Dr. Mario and Panel de Pon). Poking at the XFB, it seems that the main menu and Yoshi are using an internal resolution of 640x480 and the N64 games 576x480?

An unrelated issue, is that resetting the game causes lag and an audio cut accordingly on some transtitions on the main menu and inside the games, it's more notorious on some than others.

This happens regardless of applied patches and with both read speed emulation options as well, it doesn't happen before resetting the console.

This is through an SD2Gecko, this was tested on Wii and GameCube hardware with the same results.

Steps to reproduce

1st Issue:

  1. Patch the game from the Swiss settings to a 1:1 Horizontal Scale.
  2. Check the horizontal scale of Dr. Mario and Panel de Pon with a 1:1 scale view of the console vide output.

2nd Issue:

  1. Load the game normally via Swiss from the SD Card.
  2. Reset the game.
  3. Observe the behaviour on the transitions. (The one from the main menu to the games and back are easy to notice)

Expected behavior

1st Issue: 1:1 Horizontal Scaling in the different titles when selecting it.

2nd Issue: Resetting the game to not cause side effects.

Relevant log output

No response

Add screenshots

XFB debug screenshots of the three games: xfb-1

xfb-2

xfb-3

Extrems commented 1 year ago

This is a known limitation with VIConfigurePan I didn't really want to touch for various reasons.

Extrems commented 1 year ago

The reset issue has been fixed in c912898. It wasn't specific to this game.