emulsify-ds / compound

Compound is the default component collection for Emulsify
https://emulsify-ds.github.io/compound/
GNU General Public License v2.0
12 stars 12 forks source link

fix(stylelint issues): Rename images folder to assets #104

Closed mariannuar closed 4 months ago

mariannuar commented 7 months ago

Summary

Since there was an update to Node 20 on Emulsify Drupal (Check PR ) and the Images folder was renamed to Assets folder, the build of the theme is failing because of it.

How to review this pull request

This PR must be tested together with this PR

Create Drupal Project: composer create-project drupal/recommended-project [PROJECT_NAME] --no-interaction

Move into the project directory cd [PROJECT_NAME]

Install Emulsify client globally npm install -g @emulsify/cli

Initialize your theme with emulsify emulsify init "[THEME NAME]"

Install the version of Drupal componentst works with Drupal 10 composer require 'drupal/components:^3.0@beta'

Install the version of emulsify_twig that work with Drupal 10 composer require 'drupal/emulsify_twig^4.0'

Move into the theme directory cd web/themes/custom/[THEME NAME]

Install Compound System emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout fix-stylelint-issues

Verify storybook and scss compiling can run and there are no stylelint issues and warnings npm install && npm run develop

amazingrando commented 4 months ago

@mariannuar During functional testing the logo component isn't rendering the image.

CleanShot 2024-03-01 at 13 26 58@2x

mariannuar commented 4 months ago

@amazingrando @josue2591 Thank you both! @josue2591 I think we can merge it :shipit:

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 1.18.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: