search

emulsify-ds / compound

Compound is the default component collection for Emulsify
https://emulsify-ds.github.io/compound/
GNU General Public License v2.0
13 stars 10 forks source link

[BUG] Installing Compound via the Emulsify CLI results in missing .scss files from the component structure. #115

Open jimz0r opened 5 months ago

jimz0r commented 5 months ago

Describe the bug Installing Compound via the Emulisyf CLI (either by name or --repository --checkout options), results in missing .scss files found in the components folder. This results in a failed build/develop process due to missing index and component files (e.g /components/00-base/base.scss or components/00-base/04-spacing).

image

This is likely due to the outdated system.emulsify.json found in the project root. New .scss index files and changes to structure need to be added/updated.

To Reproduce Steps to reproduce the behavior:

  1. Use emulsify init "MY_THEME" within a Drupal project to intirialize Emuslify theme build.
  2. Navigate to "MY_THEME"
  3. Use emulsify system install compound or emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout 2.0.0 to install the Compond system.
  4. Run npm install
  5. Run npm run develop or npm run build.

Expected behavior After installing Compound via the Emuslify CLI, all files included in the repository should be present within the components stucture. This should result in a successful build/develop process.

Desktop

karldivad commented 4 months ago

I couldn't even install it, using Node 20.13.0.

Case 1:

Case 2:

franxo commented 4 months ago

Hi, Same issue as @karldivad mentioned

jimz0r commented 3 months ago

@karldivad confirmed, getting the same issue.

bariman commented 3 months ago

getting the same issue as @karldivad , using Node 20.14.0. @callinmullaney do you have any updates on the issue?

maheshpih commented 2 months ago

Hi there, facing the same issue as @bariman ... ❯ emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout 1.18.0

ERROR Unable to install system assets and/or required components: Error: ENOENT: no such file or directory, lstat '/Users/username/.emulsify/cache/systems/ba74aaaabd9722679f9a856e78fc9f80/compound/components/00-base/01-colors'

EDIT: Strangely - it seemed to have installed Compound despite the error. It indicated so when I deleted the directory indicated in the ~/.emulsify/cache path and re-ran the install - that's when i realized that the system was indeed installed despite the error msg.

MinhInBlack commented 2 months ago

I am too currently experiencing this issue. It keeps looking into the incorrect folder when its generating a different folder. Has anyone found a fix yet?

calebtr-metro commented 2 months ago

I believe the hash mismatch noted by karldivad means that this likely an issue with emulsify-cli, not with compound.

webcultist commented 1 month ago

"The system you attempted to install (compound) is invalid, as it does not contain a valid configuration file." - everything freshly installed, I get the same error.

callinmullaney commented 1 month ago

Hello everyone. Apologies for the delay. I have a coworker looking into this as it does appear to be sourced from the CLI and not compound. We are comparing the CLI's expected system schema (https://github.com/emulsify-ds/emulsify-cli/blob/develop/src/schemas/system.json) with Compound's system.emulsify.json using a json validator (https://www.jsonschemavalidator.net/) - As to be expected there is the following error with the CLI's schema Error when resolving schema reference 'variant.json#/definitions/platform'. Path 'properties.variants.items.anyOf[0].properties.platform', line 49, position 27.

deepsimran77 commented 1 month ago

I am getting the same error while installing the 'compound' system that configuration file is invalid.

sryanb commented 3 weeks ago

Same issue. This can be worked around by manually installing Compound (download the compound zip, copy files/folders into theme).