Closed joetower closed 1 year ago
@callinmullaney Thank you!
:facepalm: I totally didn't realize we were changing the theme based on OS light/dark theme preferences.
All your feedback should be addressed now. Please give it another look.
@mndonx When you have a chance, could you please give this another look and if it looks good to you we can merge. :+1:
@callinmullaney @mndonx I think this is ready for another look.
The pull quote now has:
aside
HTML element (as discussed with Inclusive Web)aria-label
can be added to the aside
element (as discussed with Inclusive Web) and includes a default value (in a CMS, this should likely be a required field)pull-quote__quote
)Thank you!
:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Summary
This PR fixes/implements the following bugs/features
pull-quote
component (modeled after one of our latest projects)Making the existing
pull-quote
component which includesfigcaption
andstyle
options.Documentation Update (required)
If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.
How to review this PR
npm run develop