feat: adding pull-quote component

emulsify-ds / compound

Compound is the default component collection for Emulsify

https://emulsify-ds.github.io/compound/

GNU General Public License v2.0

12 stars 12 forks source link

Closed joetower closed 1 year ago

joetower commented 2 years ago

Summary

This PR fixes/implements the following bugs/features

Making the existing pull-quote component which includes figcaption and style options.

Documentation Update (required)

If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.

How to review this PR

pull-quote

joetower commented 2 years ago

@callinmullaney Thank you!

:facepalm: I totally didn't realize we were changing the theme based on OS light/dark theme preferences.

All your feedback should be addressed now. Please give it another look.

joetower commented 2 years ago

@mndonx When you have a chance, could you please give this another look and if it looks good to you we can merge. :+1:

joetower commented 1 year ago

@callinmullaney @mndonx I think this is ready for another look.

The pull quote now has:

[x] the aside HTML element (as discussed with Inclusive Web)
[x] an aria-label can be added to the aside element (as discussed with Inclusive Web) and includes a default value (in a CMS, this should likely be a required field)
[x] made the variable names consistent (pull-quote__quote)

Thank you!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: