Closed mndonx closed 1 year ago
@callinmullaney @joetower Thanks! I've moved the aria-label into the pager__attributes.
@ModulesUnraveled
- [x] Let's use array numbers to get rid of
0
s.- [x] Make the current page more obvious, and add a
current
to each example.- [x] Add
aria-current="page"
to the current link.- [x] Please check to see what the Drupal text is for "first" and "last"
- [x] You can remove all of the empty
attributes
from yaml files- [x] Add
role="navigation"
to the nav
Also:
pager-uuid
-- I can't find this anywhere, and not sure why it was there. Let me know what you think! Amanda
Note to self to adjust item padding at small widths
:tada: This PR is included in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Summary
This PR improves the Pager component for Compound.
add_attributes
to template (to make it easier to extend them when we implement them in other components)pager-ellipses.yml
topager-next-ellipses.yml
to matchprev
example for consistencyHow to review this PR
feat-pager
branchnpm run develop