emulsify-ds / compound

Compound is the default component collection for Emulsify
https://emulsify-ds.github.io/compound/
GNU General Public License v2.0
12 stars 12 forks source link

feat: Pager component: adding first and last and adding addAttributes #41

Closed mndonx closed 1 year ago

mndonx commented 2 years ago

Summary

This PR improves the Pager component for Compound.

How to review this PR

mndonx commented 1 year ago

@callinmullaney @joetower Thanks! I've moved the aria-label into the pager__attributes.

mndonx commented 1 year ago

@ModulesUnraveled

  • [x] Let's use array numbers to get rid of 0s.
  • [x] Make the current page more obvious, and add a current to each example.
  • [x] Add aria-current="page" to the current link.
  • [x] Please check to see what the Drupal text is for "first" and "last"
  • [x] You can remove all of the empty attributes from yaml files
  • [x] Add role="navigation" to the nav

Also:

Let me know what you think! Amanda

mndonx commented 1 year ago

Note to self to adjust item padding at small widths

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.12.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: