emulsify-ds / compound

Compound is the default component collection for Emulsify
https://emulsify-ds.github.io/compound/
GNU General Public License v2.0
12 stars 12 forks source link

feat: adds logo component and improves the header/footer components #50

Closed joetower closed 1 year ago

joetower commented 2 years ago

Summary

This PR fixes/implements the following bugs/features

Explain the motivation for making this change. What existing problem does the pull request solve?

Documentation Update (required)

If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.

How to review this PR

joetower commented 1 year ago

@callinmullaney Thank you for the feedback! This should be ready for another look.

joetower commented 1 year ago

@ModulesUnraveled Think I addressed all of the changes we discussed in the PG. Please take a look and let me know if I missed anything. Thank you!

codeb-a commented 1 year ago

Hey Joe. I can verify that the the logo is rendering for the header and the footer and also for the page layout. but nothing is rendering here when I click the link http://localhost:6006/?path=/story/molecules-logo--logo-example. Otherwise its functioning as intended.

joetower commented 1 year ago

Hey Joe. I can verify that the the logo is rendering for the header and the footer and also for the page layout. but nothing is rendering here when I click the link http://localhost:6006/?path=/story/molecules-logo--logo-example. Otherwise its functioning as intended.

@codeb-a Thank you! This was due to not updating the testing instructions after re-naming the component. Sorry about that. This is the correct component link: http://localhost:6006/?path=/story/molecules-logo--logo and I updated the link in the PR testing instructions.

joetower commented 1 year ago

@callinmullaney This should be ready for another look when you have time. I realized Brian never reviewed it again after I made updates.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.13.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: