Closed joetower closed 1 year ago
@callinmullaney Thank you for the feedback! This should be ready for another look.
@ModulesUnraveled Think I addressed all of the changes we discussed in the PG. Please take a look and let me know if I missed anything. Thank you!
Hey Joe. I can verify that the the logo is rendering for the header and the footer and also for the page layout. but nothing is rendering here when I click the link http://localhost:6006/?path=/story/molecules-logo--logo-example. Otherwise its functioning as intended.
Hey Joe. I can verify that the the logo is rendering for the header and the footer and also for the page layout. but nothing is rendering here when I click the link http://localhost:6006/?path=/story/molecules-logo--logo-example. Otherwise its functioning as intended.
@codeb-a Thank you! This was due to not updating the testing instructions after re-naming the component. Sorry about that. This is the correct component link: http://localhost:6006/?path=/story/molecules-logo--logo and I updated the link in the PR testing instructions.
@callinmullaney This should be ready for another look when you have time. I realized Brian never reviewed it again after I made updates.
:tada: This PR is included in version 1.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Summary
This PR fixes/implements the following bugs/features
site--header
andsite--footer
components.link_content
)header
component as themain-menu
does not yet render. Once themain-menu
is worked on the header component should pull it in properly.Explain the motivation for making this change. What existing problem does the pull request solve?
Documentation Update (required)
If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.
How to review this PR
npm run develop
header
/footer
modifiers.