emulsify-ds / compound

Compound is the default component collection for Emulsify
https://emulsify-ds.github.io/compound/
GNU General Public License v2.0
12 stars 12 forks source link

Bug in web/themes/custom/nmrugby/components/02-molecules/menus/_menu-list.twig #55

Closed mark-casias closed 1 year ago

mark-casias commented 1 year ago

Expected Behavior

_menu-list.twig uses a block that doesn't exist in list.twig.

{# List #}
{% extends "@atoms/lists/list.twig" %}
  {% block list_content %}
    {% for item in items %}
      {{ item.title }}
      {% include "@molecules/menus/_menu-item.twig" with {
        li_base_class: item_base_class,
        li_modifiers: item_modifiers,
        li_blockname: item_blockname,
      } %}
    {% endfor %}
  {% endblock %}

the block should be list__content since that is what is noted in atoms/lists/list.twig

mark-casias commented 1 year ago

same issue with _menu-item.twig. It needs to be updated to list__item__content

mark-casias commented 1 year ago

well this is weird. I was looking at the codebase to see why it changed and in git, the code is correct.. but I just installed compound to find this error.. ... never mind I guess