search

emulsify-ds / compound

Compound is the default component collection for Emulsify
https://emulsify-ds.github.io/compound/
GNU General Public License v2.0
12 stars 12 forks source link

[BUG] Table header and footer class names don't match Drupal #66

Closed mndonx closed 1 year ago

mndonx commented 1 year ago

Expected Behavior

Compound's Table template uses the classes: table__header_cell and table__footer_cell but the Drupal template (in templates/dataset/table.html.twig uses: table__heading-cell and table__footer-cell.

Current Behavior

These should be standardized.

Possible Solution

The easiest solution would be to change them in Compound, I think.

Steps to Reproduce (for bugs)

  1. Compare tables with header and footer cells from Emulsify and Drupal.
  2. See screenshot examples. Screen Shot 2022-11-02 at 10 36 19 PM Screen Shot 2022-11-02 at 10 36 47 PM

Context

I just noticed as I was theming a form in Drupal (after having styled Tables in Emulsify.)

Your Environment

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 1.13.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: