fix(74): fixing select color contrast - Githubissues

emulsify-ds / compound

Compound is the default component collection for Emulsify

https://emulsify-ds.github.io/compound/

GNU General Public License v2.0

12 stars 12 forks source link

fix(74): fixing select color contrast #77

Closed mndonx closed 1 year ago

mndonx commented 1 year ago

Summary

This PR fixes/implements the following bugs/features

Visual boundary of the select combobox lacks 3 to 1 color contrast.

Explain the motivation for making this change. What existing problem does the pull request solve?

Non text elements like boundaries, focus indicators, icons must have at least 3 to 1 color contrast against the background

Documentation update (required)

If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.

How to review this pull request

[x] Using Chrome, Open ?path=/story/atoms-forms--select-dropdowns
[x] Now measure the color contrast for the boundary of the dropdown against the background white color
[x] Check that the border has adequate color contrast (now, using the accent variable, it is #4c4c4c to #ffffff

Closing issues

Closes #74

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.10.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: