Inconsistencies in rem/em/px/$space variables

emulsify-ds / compound

Compound is the default component collection for Emulsify

https://emulsify-ds.github.io/compound/

GNU General Public License v2.0

13 stars 10 forks source link

Inconsistencies in rem/em/px/$space variables #85

Closed mndonx closed 1 year ago

mndonx commented 1 year ago

Describe the bug The Compound project contains some inconsistent usages of rem, em, and px, and also sometimes uses the $space variable and sometimes not.

To Reproduce Steps to reproduce the behavior:

View the component scss files
Note mixture of px/rem/em/$space values

Expected behavior The project should consistently use the $space variable, based on rem font values, and limit px usage as much as possible. Small adjustments can be made with px values for precision.

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 1.18.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: