fix(92): replacing deprecated spaceless tag - Githubissues

emulsify-ds / compound

Compound is the default component collection for Emulsify

https://emulsify-ds.github.io/compound/

GNU General Public License v2.0

13 stars 10 forks source link

fix(92): replacing deprecated spaceless tag #94

Closed mndonx closed 1 year ago

mndonx commented 1 year ago

Summary

This PR fixes/implements the following bugs/features

https://github.com/emulsify-ds/compound/issues/92

Replaces {% spaceless $} tag with {% apply spaceless %}

Explain the motivation for making this change. What existing problem does the pull request solve?

When using the deprecated spaceless tag, the select component breaks the page in Drupal. See this Drupal.org issue: https://www.drupal.org/project/drupal/issues/3094850

How to review this pull request

[ ] Because this doesn't appear as an error in Storybook, you will need to set up a Drupal site with Compound
[ ] Add a webform
[ ] Add a select to the webform
[ ] Ensure that the select no longer breadks the webform page in Drupal.

Closing issues

Closes #92

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.16.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: