fix(93): replacing placeimg with Picsum

mndonx commented 1 year ago

Summary

This PR fixes/implements the following bugs/features

Replaces PlaceIMG placeholder images with LoremFlickr images.

Explain the motivation for making this change. What existing problem does the pull request solve?

PlaceIMG is going away, this PR replaces placeholder images with Picsum images.

How to review this pull request

[x] View storybook:
Image, Figure, Text with Media, Cards, Grid Cards, Article, Homepage (for some of these to work, you have to uncomment out some things in the Grid Cards stories and Twig files)
[x] Ensure that they are all using Picsum instead.

Closing issues

Closes #93

mndonx commented 1 year ago

I might wanna wait on this to see if we should standardize on a service project-wide.

mndonx commented 1 year ago

@Yuvania I ended up changing this from LoremFlickr to Picsum. I think that may be what we standardize on cross-projects. I also added something to imgsrcsets to make sure it was always pulling the same image (using an ID in the URL) so it didn't swap images when you cross breakpoints. Let me know if it still looks good to you! Thank you!!

codeb-a commented 1 year ago

Can confirm that the placeholder images are now all using Picsum. Looks good!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.15.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

emulsify-ds / compound