emulsify-ds / emulsify-drupal

Drupal theme built with Storybook and Webpack
GNU General Public License v2.0
92 stars 42 forks source link

Where is card__info actually printed? #206

Closed seanr closed 3 years ago

seanr commented 3 years ago

I see a card__info block created here: https://github.com/emulsify-ds/emulsify-drupal/blob/2.x/templates/content/node--article--teaser.html.twig#L86

  {% block card__info %}
    {% trans %}Submitted by {{ author_name }} on {{ date }}{% endtrans %}
  {% endblock %}

The problem I'm having is I can't figure out how it gets output in @molecules/card/card.twig or if it even does at all, currently, and I don't see it in the page output even though my content type is configured to show it. Is this code just not working currently? I've followed the instructions for creating my own theme based on emulsify, so I'd just like to know how to get that output in the card template correctly.

As an aside, it'd be great to see more documentation around the Drupal integration, specifically examples of common stuff. I've generally had a really hard time figuring out things like this that seem like they should be simple and the docs seem to really be geared toward usage of the Emulsify backend stuff or storybook, commands, etc., not the Drupal theme integration.

ModulesUnraveled commented 3 years ago

I don't think it is getting used. I expect it was at one point, and then the base card.twig template got refactored, and that was removed without updating the Drupal template. Woops!

We have an initiative underway to update the components and Drupal templates that we ship out of the box, so this will get addressed as a part of that.

Thanks for reporting it so that I can make sure it gets cleaned up!