Closed reubenmoes closed 3 years ago
emulsify version (see releases):
node version: 2.x branch
npm (or yarn) version: 1.22.10
What you did:
git clone git@github.com:emulsify-ds/emulsify-drupal.git nvm use yarn install yarn develop
What happened:
... [./node_modules/@storybook/core-server/dist/cjs/globals/polyfills.js] 120 bytes {vendors~main} [built] + 3086 hidden modules ERROR in No files matching '/home/reuben/Downloads/emulsify-drupal-2.x/.storybook/storybook-init-framework-entry.js' were found. Child HtmlWebpackCompiler: Asset Size Chunks Chunk Names __child-HtmlWebpackPlugin_0 6.43 KiB HtmlWebpackPlugin_0 HtmlWebpackPlugin_0 Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0 ...
Reproduction repository (if necessary):
Problem description: it seems like it might be related to the move to the eslint-webpack-plugin, but i'm not 100% sure. Below is my change I made myself to resolve and continue the build.
eslint-webpack-plugin
https://github.com/emulsify-ds/emulsify-drupal/commit/2fb97c84dbf6daea8235bcaa102ba3372f0699c7
Suggested solution:
diff --git a/.storybook/webpack.config.js b/.storybook/webpack.config.js index 7f41a41..a31fb47 100644 --- a/.storybook/webpack.config.js +++ b/.storybook/webpack.config.js new _StyleLintPlugin({ configFile: path.resolve(__dirname, '../', 'webpack/.stylelintrc'), context: path.resolve(__dirname, '../', 'components'), files: '**/*.scss', failOnError: false, quiet: false, }), new ESLintPlugin({ + context: path.resolve(__dirname, '../', 'components'), extensions: ['js'], }), );
Thank you for the PR!!! It's been merged!
emulsify version (see releases):
node version: 2.x branch
npm (or yarn) version: 1.22.10
What you did:
What happened:
Reproduction repository (if necessary):
Problem description: it seems like it might be related to the move to the
eslint-webpack-plugin
, but i'm not 100% sure. Below is my change I made myself to resolve and continue the build.https://github.com/emulsify-ds/emulsify-drupal/commit/2fb97c84dbf6daea8235bcaa102ba3372f0699c7
Suggested solution: