search

emulsify-ds / emulsify-drupal

Drupal theme built with Storybook and Webpack
GNU General Public License v2.0
92 stars 42 forks source link

Update storybook dependencies so that a build succeeds #215

Closed ModulesUnraveled closed 2 years ago

ModulesUnraveled commented 3 years ago

Update nvmrc to reference v15. (This will make installing peer-dependencies happen by default)

Update storybook dependencies to latest.

sinyayadynya commented 3 years ago

Hi, did not wanted to open a new issue, as I guess it would be a child of this one:

with last 3.0.2 version of Emulsify, I had to manually install @storybook/addon-docs (https://www.npmjs.com/package/@storybook/addon-docs) in order to succeed with yarn develop, as it is referred in /components/00-base/01-colors/colors.mdx

Please let me know if I'm commenting in the wrong place and if I should open a new issue. Thanks!

rpayanm commented 3 years ago

I have the same issue as @sinyayadynya and I had to do the same.

ModulesUnraveled commented 2 years ago

Hey, just wanted to post an update here:

First, a little background: we are moving all of our default components out of emulsify-drupal and into Compound. In that repo, we've already switched from node-sass to sass (formerly known as dart-sass. The "official" version of sass going forward) and we're using node v16 (noted in the .nvmrc file.)

Okay, so with that in mind, I tried to do a quick PR to update emulsify-drupal in the meantime, but I found out that node 14 doesn't compile on M1 macs (I just got one recently), but if I update to node 16, I'd also have to update node-sass from v5 to v6, and I don't know what trickling ramifications that would create.

So... Since I can't use node 14, and don't want to spend time updating node-sass (since we're not using it going forward anyway) I think the answer to this issue is to either manually install the addon-docs package, or just delete the colors.mdx file.

In Compound, I'm going to delete the colors file since its content basically just says "hey, we could use this file, if we wanted to" ... but we never actually put it to use.

Closing for now, but if anyone has further thoughts, please feel free to re-open and add your comments.