emulsify-ds / emulsify-drupal

Drupal theme built with Storybook and Webpack
GNU General Public License v2.0
92 stars 42 forks source link

Replace node-sass package with sass npm package #217

Closed callinmullaney closed 3 years ago

callinmullaney commented 3 years ago

What happened: node-sass has been labeled as a semi-deprecated package since Oct 2020 and only receives maintenance releases.

Suggested solution: Sass (and node-sass package) recommend switching to Dart Sass (https://sass-lang.com/dart-sass) as the officially supported version. It's package has been renamed to sass https://www.npmjs.com/package/sass

mark-casias commented 3 years ago

The only breaking change I came across is with the _01-variables.scss.. The divided section will not work with dart sass..

Suggested fix

ModulesUnraveled commented 3 years ago

These steps worked great on an existing project! Thank you for your research!

Since we're in the process of abstracting our default components from emulsify-drupal to the new compound repo, I'm going to make this change over in that repo.