Closed codechefmarc closed 2 years ago
Note that this replaces PR-168
@marcb4k The functional testing was good, except that this command did not install this branch but I worked around it, emulsify init --starter https://github.com/emulsify-ds/emulsify-drupal.git --checkout issue-75-drupal-module-dependencies "My Awesome Theme"
:tada: This PR is included in version 4.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
What:
Adds module dependencies to info.yml file and removes references to those modules in composer.json file to reduce confusion. Addresses #75
Why:
Prevents installation of the created Emulsify-based theme until the correct modules (components and emulsify_twig) are installed. This helps eliminate confusion if the theme doesn't work properly without these modules installed.
How:
Added the two required modules to the dependencies section of the emulsify.info.yml file and removed the two modules from the composer.json file.
To Test:
emulsify init --starter https://github.com/emulsify-ds/emulsify-drupal.git --checkout issue-75-drupal-module-dependencies "My Awesome Theme"
to test the version on that branch.components
andemulsify_twig
modules, check Drupal appearance page to make sure the theme cannot be installed without those two modules being installed first.composer require drupal/components drupal/emulsify_twig