emulsify-ds / emulsify-drupal

Drupal theme built with Storybook and Webpack
GNU General Public License v2.0
92 stars 42 forks source link

Issue 75 drupal module dependencies #259

Closed codechefmarc closed 2 years ago

codechefmarc commented 2 years ago

What:

Adds module dependencies to info.yml file and removes references to those modules in composer.json file to reduce confusion. Addresses #75

Why:

Prevents installation of the created Emulsify-based theme until the correct modules (components and emulsify_twig) are installed. This helps eliminate confusion if the theme doesn't work properly without these modules installed.

How:

Added the two required modules to the dependencies section of the emulsify.info.yml file and removed the two modules from the composer.json file.

To Test:

codechefmarc commented 2 years ago

Note that this replaces PR-168

amazingrando commented 2 years ago

@marcb4k The functional testing was good, except that this command did not install this branch but I worked around it, emulsify init --starter https://github.com/emulsify-ds/emulsify-drupal.git --checkout issue-75-drupal-module-dependencies "My Awesome Theme"

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 4.3.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: