search

emulsify-ds / emulsify-drupal

Drupal theme built with Storybook and Webpack
GNU General Public License v2.0
91 stars 42 forks source link

Multiple php Coding standards fixes for the emulsify.php file #295

Closed rigoucr closed 9 months ago

rigoucr commented 1 year ago

What:

Coding standards fixes over emulsify.php file

Why:

Automatic php lint tools (phpcs) throws multiple errors while reading this file

How:

Replaced old code or bad practices with new good practices

To Test:

┆Issue is synchronized with this Clickup task by Unito

rigoucr commented 1 year ago

thank you @callinmullaney ! btw GH actions is failing because the GH token is missing

Screenshot 2023-08-11 at 8 35 45 AM

Update , I created a issue for that : #296

rigoucr commented 1 year ago

@callinmullaney @amazingrando I haven't been able to merge this because I have not permissions to re-run the CI

amazingrando commented 1 year ago

@rigoucr (cc: @callinmullaney) I have updated your permissions in this repo. Please try again and let me know if it works or not.

(I've been tightening security in the Emulsify organization and repositories. I apologize for causing issues.)

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 4.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: