search

emulsify-ds / emulsify-drupal

Drupal theme built with Storybook and Webpack
GNU General Public License v2.0
92 stars 42 forks source link

[BUG] Storybook 7 upgrade issue (expecting HTML snippet or DOM node) #300

Open jsheffers opened 1 year ago

jsheffers commented 1 year ago

Describe the bug I've upgraded to storybook 7.4.6 and I'm having an issue where the story won't display. I get the following error for each component.

Expecting an HTML snippet or DOM node from the story: "Palettes" of "Base/Colors".

To Reproduce Download the latest master of emulsify-drupal. Updated all values in package.json related to storybook from 7.0.7 to 7.4.0. Remove lock file, npm i, npm run dev.

Expected behavior Storybook get's updated but each individual story won't load.

Screenshots

Desktop (please complete the following information):

jsheffers commented 1 year ago

This fixes the issue and should be added to the Storybook 7 merge.
https://github.com/emulsify-ds/emulsify-drupal/issues/293#issuecomment-1636816591

Key line is this:

return Story()

jsheffers commented 1 year ago

I also had to alter the paths in package.json script to be:

"storybook": "storybook dev --ci -s ../dist,../images -p 6006",
"storybook-build": "npm run build && storybook build -s ../dist,../images -o .out",