Closed callinmullaney closed 11 months ago
@callinmullaney Following the instructions, I continue to get variables not being found errors. Should there be a step where we are telling the emulsify init
command that it should be using this PR?
@amazingrando I updated the testing directions. You're correct that the emulsify init
command should have specified this branch. To test we need to run emulsify init --checkout=feat-issue-293 [THEME NAME]
instead.
:tada: This PR is included in version 4.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
What: Resolves https://github.com/emulsify-ds/emulsify-drupal/issues/293 where compiling compound components results in an error.
Why:
Fixes an issue where the Storybook 7 upgrade broke compiling with the latest version of Compound.
To Test:
Create Drupal Project:
composer create-project drupal/recommended-project [PROJECT_NAME] --no-interaction
Move into the project directory
cd [PROJECT_NAME]
Install Emulsify client globally
npm install -g @emulsify/cli
Initialize your theme with emulsify
emulsify init --checkout=feat-issue-293 "[THEME NAME]"
Install the version of Drupal componentst works with Drupal 10
composer require 'drupal/components:^3.0@beta'
Install the version of emulsify_twig that work with Drupal 10
composer require 'drupal/emulsify_twig^4.0'
Move into the theme directory
cd web/themes/custom/[THEME NAME]
Install Compound System
emulsify system install compound
Start the watch task and run Storybook to where errors are seen
npm run develop
Note: The scss files should now compile. However, this will result in a lot of stylint warnings (examples below) but this is more of an issue with the Compound repository and not emulsify-drupal specifically.