Blockquote styled with design tokens

emulsify-ds / emulsify-ui-kit

Components connected to Figma using Design Tokens.

https://emulsify-ds.github.io/emulsify-ui-kit/

GNU General Public License v2.0

12 stars 6 forks source link

Blockquote styled with design tokens #101

Closed mariannuar closed 10 months ago

mariannuar commented 10 months ago

Description

This PR styled the Blockquote component with design tokens

How to review this pull request

[ ] Run npm run develop
[ ] Visit the component
[ ] Confirm it looks as expected in the design

Closes https://github.com/emulsify-ds/emulsify-ui-kit/issues/97

mariannuar commented 10 months ago

@amazingrando Thanks, Randy! While fixing it, I noticed that the font-sizes token are being created as px values (but without the px word. I don't know how to explain this, I'm kind of confused, sorry. Please, see image below so maybe you understand what I mean). Because of that, the font-sizes are not being displayed correctly. Is there a function or something for converting tokens px based font-sizes to rem? Or there's another way to do this? I could add the function, if needed.

Captura de pantalla 2023-08-20 a la(s) 12 20 55 a m

amazingrando commented 10 months ago

@mariannuar That is super weird. Please create an issue so we track this problem.

mariannuar commented 10 months ago

@amazingrando I just created the issue

mariannuar commented 10 months ago

@amazingrando It seems the Netlify action is still in progress 👀

amazingrando commented 10 months ago

@mariannuar I just checked and this site should not be connected to Netlify. I'm going to just merge this branch.