emulsify-ds / emulsify-ui-kit

Components connected to Figma using Design Tokens.
https://emulsify-ds.github.io/emulsify-ui-kit/
GNU General Public License v2.0
12 stars 9 forks source link

Emulsif-67: Color contrast now meets WCAG AA standards #126

Closed mariannuar closed 3 months ago

mariannuar commented 3 months ago

Summary

This PR fixes color contrast for some components to meet WCAG AA Standard

How to review this pull request

Closing issues

Closes #113

netlify[bot] commented 3 months ago

Deploy Preview for emulsify-ui-kit ready!

Name Link
Latest commit 1672e3fb27d82f09c1f0eea8c44c370d739e006a
Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/6670ce00af07d10008d0d19c
Deploy Preview https://deploy-preview-126--emulsify-ui-kit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amazingrando commented 3 months ago

@mariannuar There are two pages that have contrast errors—buttons and table typography. See attached screenshots.

CleanShot 2024-06-17 at 09 53 22@2x CleanShot 2024-06-17 at 09 52 55@2x

mariannuar commented 3 months ago

@amazingrando Thank you!!! They are fixed now, please let me know your thoughts about the use of colors. Thanks!