Closed mariannuar closed 3 months ago
Name | Link |
---|---|
Latest commit | 1672e3fb27d82f09c1f0eea8c44c370d739e006a |
Latest deploy log | https://app.netlify.com/sites/emulsify-ui-kit/deploys/6670ce00af07d10008d0d19c |
Deploy Preview | https://deploy-preview-126--emulsify-ui-kit.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@mariannuar There are two pages that have contrast errors—buttons and table typography. See attached screenshots.
@amazingrando Thank you!!! They are fixed now, please let me know your thoughts about the use of colors. Thanks!
Summary
This PR fixes color contrast for some components to meet WCAG AA Standard
How to review this pull request
[x] Visit the following components in Storybook and note the Accessibility tab.
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-button--button
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-cards--card-horizontal
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-cards--card-vertical
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-menus--breadcrumbs
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-menus--inline
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-menus--social
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-typography--headings
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-typography-links--links
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-typography--tables
[x] https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-pager--basic
[x] Confirm there aren't color contrast issues anymore and they look like the design on Figma... I had to do some changes there. However, I saved a backup just in case we don't want those colors used.
Closing issues
Closes #113