Drupal Coding Standards - Githubissues

emulsify-ds / emulsify_tools

GNU General Public License v2.0

0 stars 0 forks source link

Drupal Coding Standards #2

Closed codechefmarc closed 5 months ago

codechefmarc commented 7 months ago

Summary

This PR fixes/implements the following bugs/features

Checked the code against phpcs with the Drupal standard and refactored the following
Added dependency injection to the SubThemeCommands for 3 services
Moved SubThemeGenerator to a service
Cleaned up unused use statements

Explain the motivation for making this change. What existing problem does the pull request solve?

Prepares the module for Drupal.org and best coding practices.

Documentation update (required)

No changes to documentation, command works exactly the same way as before.

How to review this pull request

[x] Pull down this repo into the /web/modules/contrib directory and switch to this branch
[x] Pull down the emulsify_drupal repo into the /web/themes/contrib directory and switch to the release-base-theme branch.
[x] Enable the Emulsify Tools module - drush en emulsify_tools
[x] Run the command drush emulsify my_awesome_theme
[x] Verify that a new sub theme is generated in /web/themes/custom/my_awesome_theme