emurnane / EmailDrivenAppsEngine

0 stars 4 forks source link

Next Wave Time and Enemy Number #24

Open emurnane opened 8 years ago

emurnane commented 8 years ago

Please leave a comment to respond to these questions. Mention the question number(s) you're answering (1, 2, 3, or 4), and feel free to link to the relevant source code in the repo.

ik226 commented 8 years ago
  1. at _shouldCreateEnemy() in controller.js, it calls GameInfoDisplay.hourSplash() when:
if (GLOBAL.HOURITR > totalhourloops + (2 * GLOBAL.FPS) && GLOBAL.ENEMIES.length === 0) {
                GLOBAL.HOURITR = 0;
                GLOBAL.HOURENEMYNUMBER = 0;
                GLOBAL.GAMEHOUR++;
                    GameInfoDisplay.hourSplash();
            }

Then, GameInfoDisplay.hourSplash() calls Utils.UTCHourToLocalHour(GLOBAL.GAMEHOUR), that does Date.setUTCHours(GLOBAL.GAMEHOUR). Here, setting UTC hours with GLOBAL.GAMEHOUR , which starts from 0, makes the date's hour value to be 8 (I believe that's because of our time zone...) . So, I should say this is default.

emurnane commented 8 years ago

Thanks, Re: 1 — let's change this so the game starts at 6AM (see issue https://github.com/emurnane/EmailDrivenAppsEngine/issues/34) (i.e., test to be sure game starts at 6AM regardless of what timezone the player is located in)