emustudio / edigen

Emulator Disassembler Generator
GNU General Public License v3.0
4 stars 0 forks source link

Please update disassembler template to reflect current situation in emuLib #12

Closed vbmacher closed 11 years ago

vbmacher commented 12 years ago

The disassembler changed from SimpleDisassembler to AbstractDisassembler and Decoder is already included.

Also please consider if it would be a good step to generalize disassembler and move the code (of a template) into emuLib directly. In fact, only static tables of disassembler formats and values need really to be generated, everything else can be generalized. These tables can be passed either in constructor, or through setters (if we would like to allow change format at runtime) to the disassembler.

sulir commented 12 years ago

I've updated both Edigen and EdigenCPU, but I can't try whether it works because the standard-mem plugin is not yet updated.

I don't think it would be beneficial to move all disassembler code except the format-value table to emuLib. One of the advantages of the template is that a user can supply own formatting logic (e.g. %+5S would be 5-char right-padded uppercase string) simply by modifying the template.

vbmacher commented 12 years ago

OK, I agree. So I leave AbstractDisassembler as it is and probably we can close https://github.com/vbmacher/emuLib/issues/10

sulir commented 11 years ago

I have updated edigen-cpu again to reflect emuLib changes and it works fine now. So I think we can close this.