search

emvaized / kde-snap-assist

KWin script for KDE Plasma which suggests other window thumbnails on snap
https://store.kde.org/p/1875687
GNU General Public License v3.0
108 stars 6 forks source link

Bug: Titlebar is visible sometimes #13

Closed margual56 closed 2 years ago

margual56 commented 2 years ago

I'm on Wayland (on ArchBTW), and the titlebar is visible sometimes:

Screenshot

It seems to only occur when it is selecting some position at the bottom (bottom left or right, or horizontal snapping in the bottom as seen in the screenshot).

That window can be moved around, and if closed the snapping script stops working.

Note: Did not test on X11

emvaized commented 2 years ago

It seems that X11BypassWindowManagerHint flag, which sets the window as titlebar-less, does not work reliably on Wayland. It can be replaced with FramelessWindowHint flag, which solves the problem on Wayland — but breaks the script on X11, as the assist's window becomes invisible.

emvaized commented 2 years ago

Alright, it turns out you could specify both flags at the same time, and it seems to be working fine in both X11 and Wayland. Would be great if you could test and confirm it by installing the latest version from the dev branch).

margual56 commented 2 years ago

Alright, it turns out you could specify both flags at the same time, and it seems to be working fine in both X11 and Wayland. Would be great if you could test and confirm it by installing the latest version from the dev branch).

If I did it correctly, I think the bug is still present:

2022-08-13_01-50

emvaized commented 2 years ago

Did you re-login to Plasma after install?

emvaized commented 2 years ago

It seems to me you're still running the old version, as "Change layout" button's icon should be different in current "dev" version

emvaized commented 2 years ago

The fix is now included in new version 1.3 and the main branch.

emvaized commented 2 years ago

Closing this as I no longer can reproduce the issue. Please feel free to reopen if your issue remains.

margual56 commented 2 years ago

Can confirm it is fixed, sorry for the bad debugging on my part.

Nice job! :)