emvaized / kde-snap-assist

KWin script for KDE Plasma which suggests other window thumbnails on snap
https://store.kde.org/p/1875687
GNU General Public License v3.0
97 stars 6 forks source link

Bug: Snapping does not resize the window #14

Closed margual56 closed 1 year ago

margual56 commented 1 year ago

On Wayland, ArchBTW.

When snapping, the window does not resize horizontally: it retains whatever size it had before. Is that intentional?

Note: Did not test on X11

emvaized commented 1 year ago

I can confirm this — on Wayland some windows get resized normally for me (such as Kate), and some don't (such as Konsole). I would cautiously assume that this is a problem with the window manager itself on Wayland — because the script uses the only way possible for a KWin script to resize the window, and on X11 it works just fine.

margual56 commented 1 year ago

Wow! Maybe we could submit the bug to KWin then? (here)

emvaized commented 1 year ago

Sure, let's try it. What are your system specs — KDE frameworks version and stuff? As I haven't updated mine for a little while

emvaized commented 1 year ago

And could you also confirm — does the window width remains unchanged only for specific windows (like Konsole in my case, and Kate resizes fine), or for all windows?

margual56 commented 1 year ago

And could you also confirm — does the window width remains unchanged only for specific windows (like Konsole in my case, and Kate resizes fine), or for all windows?

In my case this happens for all windows (that I have tried, which are Alacritty, Thunderbird, Firefox, Kate, Settings, Dolphin and vscode)

Sure, let's try it. What are your system specs — KDE frameworks version and stuff? As I haven't updated mine for a little while

  • KDE Plasma Version: 5.25.4
  • KDE Framework Version: 5.96.0
  • Qt Version: 5.15.5
  • Kernel: 4.18.16-zen1-1
  • Graphics Platform: Wayland

Thank you!

emvaized commented 1 year ago

I created a bug report. Let's see how it goes: https://bugs.kde.org/show_bug.cgi?id=457822

emvaized commented 1 year ago

I think I'll be closing this for now. If you'll find any information confirming that this is not a KWin's bug, but a problem with the script — or a possible workaround, please feel free to reopen.

semarainc commented 1 year ago

sorry for reopening this issue but i found this script Link: https://github.com/qewer33/Exquisite (handle window snap like windows 11) It works on wayland on resizing window, so i guess maybe it is not a KWin's bug but a bug on the script

maybe you can take a look if you don't mind Thanks

emvaized commented 1 year ago

It seems that it uses the same geometry API, but in a some different way. I just implemented the same for test in the dev branch — would be great if you could check and confirm if it's working.

For this you'd need to:

UPD: Fix is now on the main branch, and included in 1.4 release