search

emvaized / selecton-extension

Selecton browser extension provides popup with actions on text selection in Chrome and Firefox
Other
77 stars 17 forks source link

Unit and time conversion issues #13

Closed sbozdemir closed 2 years ago

sbozdemir commented 3 years ago

Hey there! This is a great add-on, good job with that.

Only drawback I've experienced with is unit and time conversions. Currency conversions seems working fine. I used the site given below for testing different units and time zones and most of them failed.

Test site: https://blogs.opera.com/desktop/2017/08/time-zone-unit-converters-highlight-opera-48-beta-release/

Also working time conversions displays results in 12Hour format and sometimes with colon(":") sign at the end of it. It is a bit confusing. Can you represent them in 24 Hour format or add am/pm indicator?

Thank you for the hard work.

Screenshot 2021-11-03 145054

emvaized commented 3 years ago

Thanks for your feedback and kind words! Yes, I would say time convert button is currently the most unreliable amongst all. In order for it to work time text should be in precise format, so that for example "2:00 PM" would be recognized, and "2:00pm" would not be.

Yesterday I uploaded new update 3.3.9, which includes some improvements for the time button algorythm — it improves the situation a bit: illustration

This update is already available on Firefox, and should be approved for Chrome within few days. But I would say this feature is still far from perfect, and still relies a lot for text to be in standard time format.

Actually, a lot of timezones from this page were not even supported by Selecton until now. So thanks a lot for sharing, I will add missing timezones shortly.

emvaized commented 2 years ago

In past few updates (3.3.9 and 3.4.0) I made some improvements to unit and time recognition, so now Selecton handles >70% of use cases on the mentioned page, except some rare cases which I decided not to handle for better performance of the extension.

Please feel free to reopen this issue if bad unit recognition will still be the case for you in everyday use.