emyl / puppet-vagrant

A puppet module for installing vagrant and, optionally, boxes and plugins.
MIT License
5 stars 9 forks source link

Symlinks in modules are unsupported. #4

Open razorsedge opened 9 years ago

razorsedge commented 9 years ago

You should clean out the symlinks in spec/fixtures before creating the package.

$ puppet module install emyl-vagrant
Notice: Preparing to install into /etc/puppet/modules ...
Notice: Downloading from https://forgeapi.puppetlabs.com ...
Warning: Symlinks in modules are unsupported. Please investigate symlink emyl-vagrant-0.1.0/spec/fixtures/modules/vagrant/lib->..
Warning: Symlinks in modules are unsupported. Please investigate symlink emyl-vagrant-0.1.0/spec/fixtures/modules/vagrant/manifests->..
Notice: Installing -- do not interrupt ...
/etc/puppet/modules
└── emyl-vagrant (v0.1.0)
amosshapira commented 9 years ago

Another aspect of this - the symlinks pointing to "." cause vagrant-aws' rsync to get into an infinite recursion copying "lib" into itself and fail.

i11 commented 9 years ago

Hi! I've forked both this and mjanser's modules to resolve outstanding issues. Have a look at https://github.com/unibet/puppet-vagrant and let me know if there is anything lacking.