enBloc-org / kindly

Open source repository for the development of Kindly
GNU General Public License v3.0
18 stars 21 forks source link

Default image display for profile picture in ConversationCards #341

Closed camelPhonso closed 1 month ago

camelPhonso commented 1 month ago

Description of the Bug

When a user's profile picture can not be retrieved the display of the ConversationCard.tsx should show the default image in the codebase. This behaviour is seen when there is no image provided and should be the same if the image cannot be displayed.

What should happen instead

Right now in our seed data the images being referenced are not available in the development buckets so the cards show the alt description instead and the sizing of the profile picture is altered. 366962472-28dc0a57-0c7b-4b02-8bfe-a7ae97262949

Steps to reproduce this bug

  1. log in as one of the test users
  2. visit /conversations

What could we do to solve this bug?

Currently the code in ConversationCard.tsx will evaluate if there is an image url available and if not it will display a default image. We should default to the same if there image is referenced but cannot be displayed or at the very least we should maintain the size and styling of the profile picture display even if we can only see the alt description for it

Assignment

This issue is free for anyone to take

AnyaVeselova commented 1 month ago

!request

github-actions[bot] commented 1 month ago

πŸ€– meep morp!

Thank you for your contribution @AnyaVeselova - this Issue is assigned to you as requested ✨

πŸ”Ž Please keep in mind that in order to give everyone a chance to contribute Issues may be unassigned if they go stale. You will be warned if the Issue is marked as stale at any point.

πŸ”Ž Please review our documentation for guidance on:

πŸ’‘ The core team is available for any help and will try to respond to any comments in this Issue or questions on discord as quickly as possible.

Happy coding ! πŸ¦†