search

enFaust / MediaServer

Task for EPAM
0 stars 0 forks source link

Class Objects was add it to validation class #23

Closed enFaust closed 6 years ago

enFaust commented 6 years ago

I'm sorry. I add "Fix AccessFilter" to this pull request. How can I delete changes from pull request?

vatolinrp commented 6 years ago

it makes no sense replacing login == null by Objects.isNull(login). use equals and hashcode of java.util.Object, for example, in your model classes to avoid the implementation of those methods. Here: https://baptiste-wicht.com/posts/2010/04/java-7-the-new-java-util-objects-class.html

vatolinrp commented 6 years ago

I'm sorry. I add "Fix AccessFilter" to this pull request. How can I delete changes from pull request? 1) do a git revert 2) do interactive git rebase where you delete the commit and then do a a git force push I recommend you to try the second approach

vatolinrp commented 6 years ago

please, don't let your PR be open for several weeks.