enGits / engrid

ENGRID is a mesh generation software with CFD applications in mind. It supports automatic prismatic boundary layer grids for Navier-Stokes simulations and has a Qt based GUI.
Other
146 stars 55 forks source link

create surface mesh always results in crash #12

Closed wyldckat closed 12 years ago

wyldckat commented 12 years ago

Original Report:

8 [enGrid] bug crash always 2011-08-28 20:59 2011-12-26 15:48
dominikchrist  
wyldckat  
normal  
resolved 1.3beta  
fixed  
none    
none  
create surface mesh always results in crash
Hello everyone,

for testing, I created a simple cube using a CAD program. I can import the cube as STL without problems. Next, I want to create a surface mesh but engrid crashes everytime I click "ok" in the window called "surface mesher".

To reproduce:
1) Import->STL and select "Box.STL" (attached)
2) Mesh-> create/improve surface mesh and hit "ok"

Thanks for your help in advance
Best regards
-Dominik

Box.STL (1 KB) 2011-08-28 20:59
wyldckat commented 12 years ago
Notes

(0000017)
wyldckat  
2011-08-29 11:21   Greetings Dominik,

You are using enGrid in which operating system? Linux or Windows?

Best regards,
Bruno


(0000018)
dominikchrist  
2011-08-29 12:40   Hi Bruno,
thanks for taking a look at this.
It's a freshly installed Ubuntu 11.04 64bit.

-Dominik

(0000019)
wyldckat  
2011-08-29 13:46   Hi Dominik,

OK, the bug is already somewhat known, at least if we follow your description.

For more information about using enGrid, please read this tutorial: http://engits.eu/wiki/index.php/Tutorials/Version1.3/DamperDuct [^]
It's not complete yet, but at least it's already explained there that one must define "acceptable" values for the parameters available ;)

More specifically, it's the following section I'm talking about: http://engits.eu/wiki/index.php/Tutorials/Version1.3/DamperDuct#Create_Surface_Mesh [^]

Best regards,
Bruno

(0000021)
wyldckat  
2011-08-30 15:56   OK, I've finally been able to reproduce the error. Apparently I made a wrong assumption about it being related to uninitialized variables.

This can only be reproduced if the global option "enable undo+redo" is disabled, which is the default.

The reason for the crash: the file should be _interactively_ saved first before the meshing actually starts. Reason: GUIs launched from slave threads will result in crashes.

(0000023)
wyldckat  
2011-08-30 16:34   
(edited on: 2011-08-30 17:32)
Temporary fix in branch windows-1.3, commits b6f2157816d336c94ba46f1fa8d552179fb4ffc7 + 5c2fbc13e22fc9ff515f0feda9c30c362bf3e9f2.
Since it's on the windows-1.3 branch, it will only affect the next release of enGrid for Windows, at least for now.

edit: this fix doesn't work in Linux. The error dialogue is still somehow created on the wrong thread.

edit2: commit 9fad52b5ddcde32cabc371f884ed8c1c5aba0c22 on the windows-1.3 branch is compatible with both Linux and Windows.

The temporary fix emits an error message to the user claiming that the file needs to be saved before the requested operation or after the current operation is completed.


(0000041)
wyldckat  
2011-09-08 11:16   New installers released for enGrid 1.3beta on Windows:
https://sourceforge.net/projects/wyldckat.u/files/enGrid/ [^]
The ones with the name "enGrid_1.3beta_2011-09-08_setup_win*_MSVC2008.exe" have these temporary fixes.

(0000060)
wyldckat  
2011-12-26 13:51   These changes have already been merged into release-1.3, but I still need to reproduce this on Linux before closing this bug report.

(0000062)
wyldckat  
2011-12-26 15:48   The following sentence was no longer true in the latest tests:
«This can only be reproduced if the global option "enable undo+redo" is disabled, which is the default.»

Either way, since the branches release-1.3 and windows-1.3 have been successfully merged, this bug report can be considered to be fixed.
wyldckat commented 12 years ago

Attachments now at https://gist.github.com/3072035 :