search

enGits / engrid

ENGRID is a mesh generation software with CFD applications in mind. It supports automatic prismatic boundary layer grids for Navier-Stokes simulations and has a Qt based GUI.
Other
143 stars 55 forks source link

libengrid\meshpartition.cpp(332) : warning C4553: '==' : operator has no effect; did you intend '='? #20

Closed wyldckat closed 12 years ago

wyldckat commented 12 years ago

MSVC2008 gives this warning:

  libengrid\meshpartition.cpp(332) : warning C4553: '==' : operator has no effect; did you intend '='?

It refers to "found == true;" from here:

bool MeshPartition::hasBC(vtkIdType id_node, int bc)
{
  bool found = false;
  for (int j = 0; j < n2bcGSize(id_node); ++j) {
    if (n2bcG(id_node, j) == bc) {
      found == true;
      break;
    }
  }
  return found;
}

This is a clear indication that something is not right here...

wyldckat commented 12 years ago

@ogloth: I assigned this to you because you're the one who knows how to debug this method!