search

enabling-languages / scripts-fr-an

Addons to support additonal writing system (scripts) on Android Firefox
Mozilla Public License 2.0
2 stars 2 forks source link

ASSOCIATE MENUID WITH SPECIFIC WINDOW - preliminary review of togglegraphite-an #6

Open andjc opened 11 years ago

andjc commented 11 years ago

To obtain a positive full review the following issues need to be addressed:

3) You seem to assume both that there may only every be one browser window and that there may be many. You need to associate your menuId with a particular window rather than having a single global that applies to all windows.