enactjs / enact

An app development framework built atop React that’s easy to use, performant and customizable.
http://enactjs.com
Apache License 2.0
316 stars 31 forks source link

WRQ-246: Fix `SpotlightRootDecorator` to not throw errors when non-enact app imports spotlight #3253

Closed juwonjeong closed 3 months ago

juwonjeong commented 4 months ago

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

Checklist

Issue Resolved / Feature Added

When spotlight module is transpiled, .less file under the styles folder does not transpiled to the .css file. Because app developer can import @enact/spotlight/styles/mixins.less file to use mixins in their code. However, in SpotlightRootDecorator.js code import debug.less directly and it cause less dependency issue in non-enact app.

I created the file which import styles/debug.less in the SpotlightRootDecorator folder to make .less file transpiled to the .css

Resolution

Create debug.less file in the SpotlightRootDecorator folder and make SpotlightRootDecorator.js to use this file.

Additional Considerations

Links

WRQ-246

Comments

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.25%. Comparing base (c8490da) to head (21fd44d). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3253 +/- ## ======================================== Coverage 82.25% 82.25% ======================================== Files 152 152 Lines 7084 7084 Branches 1864 1864 ======================================== Hits 5827 5827 Misses 986 986 Partials 271 271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MikyungKim commented 4 months ago

Let's add a changelog for this.

juwonjeong commented 4 months ago

@MikyungKim, I added the changelog.