enactjs / enact

An app development framework built atop React that’s easy to use, performant and customizable.
http://enactjs.com
Apache License 2.0
316 stars 31 forks source link

WRQ-20060: Converted sandstone components` style to SCSS: Icon --> MediaOverlay #3258

Closed ion-andrusciac-lgp closed 3 months ago

ion-andrusciac-lgp commented 4 months ago

Checklist

Issue Resolved / Feature Added

In order to migrate to SCSS, each Sandstone component styling must be converted one at a time.

Resolution

Converted additional mixins: input-placeholder, vendor-opacity, border-box

Additional Considerations

When converting to SCSS, we got some warnings regarding nesting and wrapped properties in '&' according to the new CSS rule.

Links

WRQ-20060

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.25%. Comparing base (33376f7) to head (93b261b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/convert-to-SCSS #3258 +/- ## ======================================================== Coverage 82.25% 82.25% ======================================================== Files 152 152 Lines 7084 7084 Branches 1864 1864 ======================================================== Hits 5827 5827 Misses 986 986 Partials 271 271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.