codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.31%. Comparing base (
daf593c) to head (f36237e). Report is 9 commits behind head on develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #3278 +/- ## =========================================== + Coverage 82.27% 82.31% +0.04% =========================================== Files 152 152 Lines 7090 7090 Branches 1866 1866 =========================================== + Hits 5833 5836 +3 + Misses 986 984 -2 + Partials 271 270 -1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checklist
Issue Resolved / Feature Added
The last input type is not recognized properly when
requestLastInputTypeis called on some platforms since the function do nothing on unsupported platforms.Resolution
The issue occurs after #3218 that adds
requestLastInputType. At the moment we added this API, it is unclear that who is in charge of handling unsupported platforms among Enact, theme libraries, and apps. TherequestLastInputTypefunction's role is simply to call LS2Request so the usage of this API depends on apps' logic. We'd like to remove platform checking and make this function to call LS2Request always. It means that Enact does not involve checking if the platform is supported. So, theme libraries or apps should check the availability.Additional Considerations
On unsupported platforms, LS2Request API covers warnings so
requestLastInputTypedoes not need to cover the case.Links
WRR-1010 enactjs/sandstone#1687 Related: WRQ-6498 / #3218
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)