enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRQ-22396: Miscellaneous fix for `PageViews` and `QuickGuidePanels` #1663

Closed MikyungKim closed 3 months ago

MikyungKim commented 3 months ago

Checklist

Issue Resolved / Feature Added

PageViews and QuickGuidePanels need to be cleaned up.

Resolution

Additional Considerations

I've found some of API need to be public or modified. I'll address them in the ticket in more detail. This PR is made during the review of #1648 .

Links

WRQ-22396

Comments

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

seunghoh commented 3 months ago

The title may be WQR-22396, not WRP-22396? and the WRQ-22396 PR already exists in https://github.com/enactjs/sandstone/pull/1648?

MikyungKim commented 3 months ago

@seunghoh I've fixed the Title to Q. This PR is made while I reviewed the #1648. I couldn't make comments for files that she didn't fix so I made this PR. I was going to commit my change directly to that PR but the changes got bigger so I let @juwonjeong merge this.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.60%. Comparing base (c0c2bbb) to head (6d06797).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/WRQ-22396 #1663 +/- ## ===================================================== - Coverage 81.60% 81.60% -0.01% ===================================================== Files 148 148 Lines 6676 6674 -2 Branches 1986 1986 ===================================================== - Hits 5448 5446 -2 Misses 935 935 Partials 293 293 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.