enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRQ-32437: Fixed deletion of favorite colors for ColorPicker #1676

Closed daniel-stoian-lgp closed 3 months ago

daniel-stoian-lgp commented 3 months ago

Checklist

Issue Resolved / Feature Added

onPointerDown currently activates long press, which is ok for touch screens, but not for click.

Resolution

Removed mouse event handlers for favorite color buttons

Additional Considerations

Added an useEffect to update component state when the props for current color of favorite colors change.

Links

WRQ-32437

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (900440a) to head (18cea23). Report is 1 commits behind head on feature/ColorPickerPOC.

Files Patch % Lines
ColorPickerPOC/ColorPickerPOC.js 0.00% 9 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/ColorPickerPOC #1676 +/- ## ========================================================== - Coverage 77.10% 77.05% -0.05% ========================================================== Files 154 154 Lines 7066 7070 +4 Branches 2057 2058 +1 ========================================================== Hits 5448 5448 - Misses 1265 1268 +3 - Partials 353 354 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.