enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-3137: Fixed `Panels.Header` to show title and subtitle properly in `WizardPanels` #1695

Closed mmyelyn closed 2 months ago

mmyelyn commented 2 months ago

Checklist

Issue Resolved / Feature Added

When using WizardPanels, if the subtitles are long, they appear long for a moment and then shorten.

This is because the sizes of slotAfter and slotBefore are fixed after the subtitle is drawn. For centering of the title, the slot is measured after the element is drawn.

Resolution

I adjusted the timing of when the slot is fixed and when the subtitle and title are drawn. Specifically, I modified the subtitle and title to be drawn together when the slot is drawn.

Therefore, the phenomenon of the subtitle appearing long for a moment and then appearing short disappears.

Additional Considerations

Links

WRR-3137

Comments

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.61%. Comparing base (0d0e2df) to head (f05e5f8). Report is 2 commits behind head on release/2.9.x.develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/2.9.x.develop #1695 +/- ## ====================================================== Coverage 81.61% 81.61% ====================================================== Files 148 148 Lines 6679 6679 Branches 1989 1990 +1 ====================================================== Hits 5451 5451 Misses 935 935 Partials 293 293 ``` | [Flag](https://app.codecov.io/gh/enactjs/sandstone/pull/1695/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/enactjs/sandstone/pull/1695/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs) | `81.61% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.