enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-4591: Fix `VideoPlayer` to show only the mini feedback when pressing play/pause key #1704

Closed mmyelyn closed 2 months ago

mmyelyn commented 2 months ago

Checklist

Issue Resolved / Feature Added

There is an issue where the media slider appears when you press the play/pause button on the remote control. But only mini feedback content should appear.

Resolution

I set the initial value for playbackRate.

Previously, the playbackRate value was always set via the setPlaybackRate function when the play and pause functions were called. Now, playbackRate is set only when in seeking mode when the play/pause functions were called. Therefore, the initial value of playbackRate is missing and set to undefined. Because of this, the visibility conditions of the media slider have changed.

Additional Considerations

Links

WRR-4591

Comments

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.61%. Comparing base (1829961) to head (29d2c47). Report is 2 commits behind head on release/2.9.x.develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/2.9.x.develop #1704 +/- ## ====================================================== Coverage 81.61% 81.61% ====================================================== Files 148 148 Lines 6679 6680 +1 Branches 1990 1990 ====================================================== + Hits 5451 5452 +1 Misses 935 935 Partials 293 293 ``` | [Flag](https://app.codecov.io/gh/enactjs/sandstone/pull/1704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/enactjs/sandstone/pull/1704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs) | `81.61% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.