enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-4660: Fixed `PageViews` to not clip the shadow of navigation buttons #1708

Closed juwonjeong closed 1 month ago

juwonjeong commented 1 month ago

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

Checklist

Issue Resolved / Feature Added

The issue is that the navButtonContainer area of the PageViews was too tight, so the shadow of navigation buttons was clip when fullContents prop is true.

Resolution

Set the height of the navButtonContainer to twice the height of the button. And the formula related to topis a calculation that will position the navButtonContainer in the center.

Additional Considerations

Links

WRR-4660

Comments

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.60%. Comparing base (4e85b27) to head (4b538c1). Report is 2 commits behind head on release/2.9.x.develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/2.9.x.develop #1708 +/- ## ====================================================== Coverage 81.60% 81.60% ====================================================== Files 148 148 Lines 6681 6681 Branches 1990 1990 ====================================================== Hits 5452 5452 Misses 936 936 Partials 293 293 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MikyungKim commented 1 month ago

Let's update PR description too.