WRR-977: Fixed Scroller with editable prop to move items or complete edit mode when keydown event fired in pointer mode

juwonjeong commented 1 month ago

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

Checklist

[x] I have read and understand the contribution guide
[x] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added

When selecting an item in an editable scroller and pressing the 5-way keys (e.g. Left, Right, Enter, Down) in pointer mode, the item does not move or the edit mode does not complete.

Resolution

When 5-way key is pressed in pointer mode, only handleGlobalkeyDownCapture function is called. So I added logic in global keydown handler.

Additional Considerations

More details are available at https://github.com/enactjs/sandstone/pull/1657.

Links

WRR-977 https://github.com/enactjs/sandstone/pull/1657

Comments

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.57%. Comparing base (572aa7f) to head (b4b0f24). Report is 1 commits behind head on release/2.9.x.develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/2.9.x.develop #1713 +/- ## ====================================================== Coverage 81.57% 81.57% ====================================================== Files 148 148 Lines 6681 6681 Branches 1990 1990 ====================================================== Hits 5450 5450 Misses 938 938 Partials 293 293 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MikyungKim commented 1 month ago

Please resolve the merge conflict.

enactjs / sandstone