enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-4628: Added `jumpBackwardAriaLabel` and `jumpForwardAriaLabel` props #1714

Closed juwonjeong closed 1 month ago

juwonjeong commented 1 month ago

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

Checklist

Issue Resolved / Feature Added

We ​​need to allow overriding the aria-label of JumpButtons in MediaControls

Resolution

Added jumpBackwardAriaLabel and jumpForwardAriaLabel props

Additional Considerations

Links

WRR-4628

Comments

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.60%. Comparing base (7b62565) to head (4221af5). Report is 1 commits behind head on release/2.9.x.develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/2.9.x.develop #1714 +/- ## ====================================================== Coverage 81.60% 81.60% ====================================================== Files 148 148 Lines 6681 6681 Branches 1990 1990 ====================================================== Hits 5452 5452 Misses 936 936 Partials 293 293 ``` | [Flag](https://app.codecov.io/gh/enactjs/sandstone/pull/1714/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/enactjs/sandstone/pull/1714/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=enactjs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.