enactjs / sandstone

The set of components for an Enact-based application targeting smart TVs
Apache License 2.0
22 stars 3 forks source link

WRR-4972: Fixed PageViews dot indicator to be centered #1720

Closed juwonjeong closed 1 month ago

juwonjeong commented 1 month ago

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

Checklist

Issue Resolved / Feature Added

Dot indicator of PageViews needs to be centered

Resolution

Fixed height of past and future step icon in pageIndicator to make circle icon which forms page indicator to be centered

Additional Considerations

Links

WRR-4972

Comments

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.72%. Comparing base (b10fe56) to head (747d9ad). Report is 8 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1720 +/- ## =========================================== + Coverage 81.59% 81.72% +0.12% =========================================== Files 148 148 Lines 6677 6719 +42 Branches 1987 2004 +17 =========================================== + Hits 5448 5491 +43 + Misses 936 935 -1 Partials 293 293 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MikyungKim commented 1 month ago

Closing this in favor of https://github.com/enactjs/sandstone/pull/1730.